Add support for Label Styles V1 like #13
Conversation
There was a problem hiding this comment.
Nice work!
Regarding support for both XF.Style and style widgets, I want to keep Fabulous the easiest to use possible. We should avoid adding too many ways of doing the same thing.
So I think we should aim to support style widgets by default.
This extension will be useful for the compatibility package to migrate from v1 to v2. This will let people slowly move to v2.
So for now, I'll accept your PR but it'll be removed after we implement style widgets.
I'll try to find a solution for the Widgets.register<Xamarin.Forms.Style> that is not possible, once solved, this should enable you to implement style widgets :)
| @@ -50,6 +50,7 @@ module View = | |||
|
|
|||
| module Label = | |||
| let Text = Attributes.defineBindable<string> Xamarin.Forms.Label.TextProperty | |||
| let Style = Attributes.defineBindable<Style> Xamarin.Forms.Label.StyleProperty | |||
There was a problem hiding this comment.
The StyleProperty is actually coming from Xamarin.Forms.NavigableElement, you can put it in its own module module NavigableElement.
This way your extension can be applied to IViewWidgetBuilder and be available to all controls :)
There was a problem hiding this comment.
Thanks for the review. Updated following your suggestions :)
…ension available for all controls
Yeah Agreed |
This PR Adds initial support for #10 . This add a v1 like way of defining styles.
The original idea was to have a dedicated widgets like LabelStyle(), but for this there are some changes required on how Fabulous handles that.
I suggest we support both :
style(myStyle)This PR.style( LabelStyle() .textColor )Happy to try and and achieve the second one with some assistance 😀